Messages in this thread | | | Date | Thu, 22 Dec 2022 12:07:56 +0100 | Subject | Re: [PATCH v2 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect | From | Stefan Wahren <> |
| |
Hi Umang,
Am 19.12.22 um 12:57 schrieb Umang Jain: > Drop the usage of VCHIQ_RETRY when the vchiq has connection status > VCHIQ_CONNSTATE_DISCONNECTED. Disconnected status will not be valid to > carry on a retry, replace the VCHIQ_RETRY with -ENOTCONN. > > This patch removes the usage of vCHIQ_RETRY completely and act as > intermediatory to address the TODO item: > * Get rid of custom function return values > for vc04_services/interface. > > Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver") please drop this fixes tag since this commit doesn't fix a real issue and also shouldn't be applied to stable. > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 9c64d5de810e..ddb6d0f4daed 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -3641,7 +3641,7 @@ vchiq_loud_error_footer(void) > int vchiq_send_remote_use(struct vchiq_state *state) > { > if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) > - return VCHIQ_RETRY; > + return -ENOTCONN; > > return queue_message(state, NULL, MAKE_REMOTE_USE, NULL, NULL, 0, 0); > } > @@ -3649,7 +3649,7 @@ int vchiq_send_remote_use(struct vchiq_state *state) > int vchiq_send_remote_use_active(struct vchiq_state *state) > { > if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) > - return VCHIQ_RETRY; > + return -ENOTCONN; > > return queue_message(state, NULL, MAKE_REMOTE_USE_ACTIVE, > NULL, NULL, 0, 0);
| |