lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 3/5] usb: gadget: udc: add Renesas RZ/N1 USBF controller support
Hi Hervé,

On Tue, Dec 13, 2022 at 2:33 PM Herve Codina <herve.codina@bootlin.com> wrote:
> Add support for the Renesas USBF controller.
> This controller is an USB2.0 UDC controller available in the
> Renesas r9a06g032 SoC (RZ/N1 family).
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Thanks for your patch!

> --- /dev/null
> +++ b/drivers/usb/gadget/udc/renesas_usbf.c

> +#ifdef DEBUG
> +#define TRACE(_fmt, ...) trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__)
> +#define USBF_TRACE_EP_MASK 0x0ffff /* All the 16 endpoints */
> +#define TRACEEP(_ep, _fmt, ...) \
> + do { \
> + if ((1 << (_ep)->id) & USBF_TRACE_EP_MASK) \
> + trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__); \
> + } while (0)
> +#else
> +#define TRACE(_fmt, ...) do { } while (0)
> +#define TRACEEP(_ep, _fmt, ...) do { } while (0)

Please use "no_printk(fmt, ##__VA_ARGS__)" instead of dummy loops,
to avoid bad callers going unnoticed if DEBUG is not defined.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.104 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site