lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
From
On 21/12/2022 13:12, ty wrote:
> Hi, Kozlowski and Stübner,
>
> Thank you very much for pointing me in the right direction.
>
>> So how did you solve the comment "Does not look like properly ordered.
>> Don't add stuff at the end of files/lists."? What did you change to
>> solve it?
>
>> for context sorting order in that file is alphabetical by description
>
> I finally got it. It should be put right after the "Elgin RV1108 R1".
>
>> You do not wrap at 75, but at some other place. Just put it to editor
>> and check where is wrapping (count characters).
>
> The original message was:
>
>> from: DHDAXCW <lasstp5011@gmail.com>
>>
>> LubanCat 1 is a Rockchip RK3566 SBC based
>> is developed by EmbedFire Electronics Co., Ltd.
>> Mini Linux Card Type Cheap Computer Development Board
>>
>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> The longest line is "Mini Linux Card Type Cheap Computer Development
> Board", which has 53 characters. Or ... I should use the whole line as
> much as possible? Then I see why I was doing wrong. It will be fixed
> in the PATCH v5.

Yes,
because
such
commit
msg
is
also
within
75
characters
but
it
is
not
correct,
right?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.128 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site