Messages in this thread | | | Date | Wed, 21 Dec 2022 02:33:51 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH -next 1/4] blk-iocost: track whether iocg is still online |
| |
On Sat, Dec 17, 2022 at 11:05:24AM +0800, Yu Kuai wrote: > @@ -459,6 +459,8 @@ struct ioc_gq { > struct blkg_policy_data pd; > struct ioc *ioc; > > + bool online;
Nit: maybe tab align this field like the fields above it.
> +static void ioc_pd_offline(struct blkg_policy_data *pd) > +{ > + struct ioc_gq *iocg = pd_to_iocg(pd); > + struct ioc *ioc = iocg->ioc; > + unsigned long flags; > + > + if (ioc) {
How could ioc be NULL here?
| |