Messages in this thread | | | Date | Wed, 21 Dec 2022 11:33:06 +0100 | Subject | Re: [PATCH v2 5/6] dt-bindings: arm: mediatek: Add missing power-domains property | From | Krzysztof Kozlowski <> |
| |
On 21/12/2022 11:22, AngeloGioacchino Del Regno wrote: > Il 21/12/22 04:44, Allen-KH Cheng ha scritto: >> The "mediatek,mt8192-scp_adsp" binding requires a power domain to be >> specified. >> >> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock") >> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> >> --- >> .../arm/mediatek/mediatek,mt8192-clock.yaml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml >> index b57cc2e69efb..ce8dd2bfb533 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml >> @@ -40,6 +40,9 @@ properties: >> reg: >> maxItems: 1 >> >> + power-domains: >> + maxItems: 1 >> + >> '#clock-cells': >> const: 1 >> >> @@ -47,13 +50,27 @@ required: >> - compatible >> - reg >> >> +allOf: > > allOf is unnecessary here.
If you mean that "if:" can be without it, then it is better to have allOf. It grows often, so you avoid useless indentation change later.
Best regards, Krzysztof
| |