Messages in this thread | | | From | ty <> | Date | Wed, 21 Dec 2022 17:18:26 +0800 | Subject | Re: [PATCH v2] arm64: dts: rockchip: Add RK3566 LubanCat 1 |
| |
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2022年12月21日周三 17:05写道: > > On 21/12/2022 10:01, ty wrote: > > thanks. I am really sorry. > > > > I fixed this based on your feedback in the PATCH V2 content. Regarding > > the dts issue, I used the kernel-5.15 kernel adaptation before, which > > may not be perfect at that time. > > Do not send patches based on v5.15. This is some very old kernel. We do > not work on such stuff.
Thank you for your kindly reminder. We have modified the whole .dts file based on v6.2 kernel and follow the generic-name-regulation[0] in [PATCH v4]. Because it was basically a whole rewrite, so I decided to send a new PATCH v4.
[0] https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> > The comment was: > "Node names should be generic, so at least with regulator prefix or suffix."
Yes. Node names are all changed in [PATCH v4].
-- Y. T. Zhong Student of The University of Hong Kong, major in Computer Science. E-mail: zonyitoo@gmail.com
| |