Messages in this thread | | | Date | Tue, 20 Dec 2022 23:27:17 +0100 | Subject | Re: [PATCH v3 1/2] remoteproc: elf_loader: Update resource table name check | From | Philippe Mathieu-Daudé <> |
| |
On 20/12/22 13:50, Mukesh Ojha wrote: > Hi, > > On 12/20/2022 1:31 PM, Srinivasa Rao Mandadapu wrote: >> Update the way of checking resource table name with prefix >> substring search instead of complete string search. >> In general Qualcomm DSP binary is prepared by combining different ELFs', >> hence section header name (e.g. .resource_table), appended with ELF name >> to differentiate with same section(e.g. resource_table.ac_bin_process) of >> different ELFs'. >> Example readelf output of DSP binary: >> [60] .start.ac_bin_process PROGBITS >> [61] .resource_table.ac_bin_process PROGBITS >> [62] .comment.ac_bin_process PROGBITS >> > > Could we rephrase above like below ?
FWIW I agree :) I assumed Srinivasa was using a broken email client that strips newlines and packs everything.
> It could be also taken why applying > the patch. > > Update the way of checking resource table name with prefix substring > search instead of complete string search. > > In general, Qualcomm DSP binary is prepared by combining different > ELF's. Hence, section header name (e.g. .resource_table), appended > with ELF name to differentiate with same section(e.g. > resource_table.ac_bin_process) of different ELFs'. > > Example readelf output of DSP binary: > [60] .start.ac_bin_process PROGBITS > [61] .resource_table.ac_bin_process PROGBITS > [62] .comment.ac_bin_process PROGBITS > > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> > > Otherwise, LGTM. > Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> > > -Mukesh >> --- >> drivers/remoteproc/remoteproc_elf_loader.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c >> b/drivers/remoteproc/remoteproc_elf_loader.c >> index 5a412d7..77330d6 100644 >> --- a/drivers/remoteproc/remoteproc_elf_loader.c >> +++ b/drivers/remoteproc/remoteproc_elf_loader.c >> @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct >> firmware *fw) >> u64 offset = elf_shdr_get_sh_offset(class, shdr); >> u32 name = elf_shdr_get_sh_name(class, shdr); >> - if (strcmp(name_table + name, ".resource_table")) >> + if (!strstarts(name_table + name, ".resource_table")) >> continue; >> table = (struct resource_table *)(elf_data + offset);
| |