Messages in this thread | | | From | Ricardo Ribalda <> | Date | Tue, 20 Dec 2022 22:37:58 +0100 | Subject | Re: [PATCH] soc: mediatek: mtk-svs: Enable the IRQ later |
| |
Hi again Roger
I think I managed to reproduce your issue on an "asurada" Chromebook.
Sending a v2 of the patch.
Thanks again for the heads-up and sorry for the mess ;)
Thanks!
On Tue, 20 Dec 2022 at 21:44, Ricardo Ribalda <ribalda@chromium.org> wrote: > > Hi Roger > > Thanks for the heads up. > > This is the tree that I am using to test this: > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3918592/7 > ( https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3daf57d76c9e3d7c73d038ff2e43984412b503a2 > ) > > You can use this tool for kexec: > https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3953579 > > The syntax is kexec-lite --reboot --kernel /boot/Image --cmdline > "$(cat /proc/cmdline)" > > On Tue, 20 Dec 2022 at 15:50, Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > > > > > On 20/12/2022 12:03, Roger Lu (陸瑞傑) wrote: > > > Hi Matthias Sir, > > > > > > After applying this patch, SVS probes fail as below on my MT8192 platform. If > > > thing isn't too late, please do not merge this patch. I'll ask Ricardo how to > > > reproduce this issue and give the correct solution. Thanks in advance. > > > > > > > Ok, I just dropped the patch from v6.2-tmp/soc branch. > > > > Regards, > > Matthias > > > > > #MT8192 platform SVS probe fail log > > > [ 10.209430] SVSB_GPU_LOW: init02 completion timeout > > > [ 10.214402] mtk-svs 1100b000.svs: svs start fail: -16 > > > [ 10.219479] mtk-svs: probe of 1100b000.svs failed with error -16 > > > > > > Hi Ricardo, > > > > > > Could you share us how you reproduce this issue? I have MT8192 Chromebook and > > > can give it a try to reproduce the issue you encountered. Thanks a lot. > > > > > > Sincerely, > > > Roger Lu. > > > > > > On Fri, 2022-12-16 at 13:47 +0100, Matthias Brugger wrote: > > >> > > >> On 30/11/2022 12:00, AngeloGioacchino Del Regno wrote: > > >> > Il 27/11/22 21:22, Ricardo Ribalda ha scritto: > > >> > > If the system does not come from reset (like when is booted via > > >> > > kexec()), the peripheral might triger an IRQ before the data structures > > >> > > are initialised. > > >> > > > > >> > > Fixes: > > >> > > > > >> > > [ 0.227710] Unable to handle kernel NULL pointer dereference at > > >> > > virtual > > >> > > address 0000000000000f08 > > >> > > [ 0.227913] Call trace: > > >> > > [ 0.227918] svs_isr+0x8c/0x538 > > >> > > > > >> > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > >> > > > >> > Reviewed-by: AngeloGioacchino Del Regno < > > >> > angelogioacchino.delregno@collabora.com> > > >> > > > >> > > > >> > > >> Applied thanks! > > >> > > > > > > ************* MEDIATEK Confidentiality Notice ******************** > > > The information contained in this e-mail message (including any > > > attachments) may be confidential, proprietary, privileged, or otherwise > > > exempt from disclosure under applicable laws. It is intended to be > > > conveyed only to the designated recipient(s). Any use, dissemination, > > > distribution, printing, retaining or copying of this e-mail (including its > > > attachments) by unintended recipient(s) is strictly prohibited and may > > > be unlawful. If you are not an intended recipient of this e-mail, or believe > > > that you have received this e-mail in error, please notify the sender > > > immediately (by replying to this e-mail), delete any and all copies of > > > this e-mail (including any attachments) from your system, and do not > > > disclose the content of this e-mail to any other person. Thank you! > > > > -- > Ricardo Ribalda
-- Ricardo Ribalda
| |