Messages in this thread | | | Date | Tue, 20 Dec 2022 15:17:30 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/3] perf tools: Set debug_peo_args and redirect_to_stderr to correct values in perf_quiet_option |
| |
Em Tue, Dec 20, 2022 at 09:35:36AM +0200, Adrian Hunter escreveu: > On 20/12/22 05:57, Yang Jihong wrote: > > When perf uses quiet mode, perf_quiet_option sets debug_peo_args to -1, > > and display_attr incorrectly determines the value of debug_peo_args. > > As a result, unexpected information is displayed. > > > > Before: > > # perf record --quiet -- ls > /dev/null > > ------------------------------------------------------------ > > perf_event_attr: > > size 128 > > { sample_period, sample_freq } 4000 > > sample_type IP|TID|TIME|PERIOD > > read_format ID|LOST > > disabled 1 > > inherit 1 > > mmap 1 > > comm 1 > > freq 1 > > enable_on_exec 1 > > task 1 > > precise_ip 3 > > sample_id_all 1 > > exclude_guest 1 > > mmap2 1 > > comm_exec 1 > > ksymbol 1 > > bpf_event 1 > > ------------------------------------------------------------ > > ... > > > > After: > > # perf record --quiet -- ls > /dev/null > > # > > > > redirect_to_stderr is a similar problem. > > > > Fixes: f78eaef0e049 ("perf tools: Allow to force redirect pr_debug to stderr.") > > Fixes: ccd26741f5e6 ("perf tool: Provide an option to print perf_event_open args and return value") > > Suggested-by: Adrian Hunter <adrian.hunter@intel.com> > > Signed-off-by: Yang Jihong <yangjihong1@huawei.com> > > Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks, applied all patches in this series.
- Arnaldo
| |