lkml.org 
[lkml]   [2022]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config
From
Hi Babu,

On 12/19/2022 11:50 AM, Moger, Babu wrote:
>
> Forgot about this. This snippet is going to change. I have tested and works fine.
> How about this?
>
> /*
> * Update MSR_IA32_EVT_CFG_BASE MSR on one of the CPUs in the
> * domain. The MSRs offset from MSR MSR_IA32_EVT_CFG_BASE
> * are scoped at the domain level. Writing any of these MSRs
> * on one CPU is supposed to be observed by all CPUs in the domain.
> */
> smp_call_function_any(&d->cpu_mask, mon_event_config_write, &mon_info, 1);
>
>

It looks good but please drop the "supposed to be". If there is any uncertainty
then the data should be written to all CPUs, if not then that uncertain text should
be dropped.

Reinette


\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.107 / U:1.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site