lkml.org 
[lkml]   [2022]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow
Date
From


On 12/20/2022 12:47 PM, Andy Shevchenko wrote:
>> Fixes: 2373f6b9744d ("i2c-designware: split of i2c-designware.c into core and bus specific parts")
> It's not clear if the second patch you sent (about unsigned long --> u32) is
> required or not, can you clarify this in the changelog?
>

Sure will add to the changelog, it's not required to have the second
change to avoid the overflow.

>> Signed-off-by: Lareine Khawaly<lareine@amazon.com>
>> Signed-off-by: Hanna Hawa<hhhawa@amazon.com>
> This should be last part of the message body. The cutter '---' line makes it
> so, currently you finish your message with a changelog and not tags. So, you
> need to move the changelog after the cutter line.

Thanks for the info. will update.

>
>> Change Log v2->v3:
.
.
>> - return DIV_ROUND_CLOSEST(ic_clk * tSYMBOL, MICRO) - 8 + offset;
>> + return DIV_ROUND_CLOSEST_ULL((u64)ic_clk * tSYMBOL,
>> + MICRO) - 8 + offset;
> There is still a room for 'MICRO) -' part on the previous line.
> Ditto for the similar cases.

Ack will be fixed

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.036 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site