Messages in this thread | | | Date | Tue, 20 Dec 2022 17:13:54 +0100 | Subject | Re: [PATCH] drm/sprd: remove redundant error logging | From | Thomas Zimmermann <> |
| |
Hi
Am 19.12.22 um 21:55 schrieb Deepak R Varma: > On Sun, Dec 11, 2022 at 07:25:08PM +0530, Deepak R Varma wrote: > > Hello, > May I please request a review and feedback on this patch proposal?
Added to drm-misc-next. Thanks for the patch.
Best regards Thomas
> > Thank you, > ./drv > >> A call to platform_get_irq() already prints an error on failure within >> its own implementation. So printing another error based on its return >> value in the caller is redundant and should be removed. The clean up >> also makes if condition block braces unnecessary. Remove that as well. >> >> Issue identified using platform_get_irq.cocci coccicheck script. >> >> Signed-off-by: Deepak R Varma <drv@mailo.com> >> --- >> drivers/gpu/drm/sprd/sprd_dpu.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c >> index 88f4259680f1..db0bcea1d9f4 100644 >> --- a/drivers/gpu/drm/sprd/sprd_dpu.c >> +++ b/drivers/gpu/drm/sprd/sprd_dpu.c >> @@ -803,10 +803,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu, >> } >> >> ctx->irq = platform_get_irq(pdev, 0); >> - if (ctx->irq < 0) { >> - dev_err(dev, "failed to get dpu irq\n"); >> + if (ctx->irq < 0) >> return ctx->irq; >> - } >> >> /* disable and clear interrupts before register dpu IRQ. */ >> writel(0x00, ctx->base + REG_DPU_INT_EN); >> -- >> 2.34.1 >> > >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [unhandled content-type:application/pgp-signature] | |