Messages in this thread | | | Subject | Re: [PATCH net] net: fec: Coverity issue: Dereference null return value | From | Paolo Abeni <> | Date | Tue, 20 Dec 2022 15:46:56 +0100 |
| |
Hello,
On Thu, 2022-12-15 at 17:11 +0800, wei.fang@nxp.com wrote: > From: Wei Fang <wei.fang@nxp.com> > > The build_skb might return a null pointer but there is no check on the > return value in the fec_enet_rx_queue(). So a null pointer dereference > might occur. To avoid this, we check the return value of build_skb. If > the return value is a null pointer, the driver will recycle the page and > update the statistic of ndev. Then jump to rx_processing_done to clear > the status flags of the BD so that the hardware can recycle the BD. > > Signed-off-by: Wei Fang <wei.fang@nxp.com> > Reviewed-by: Shenwei Wang <Shenwei.wang@nxp.com>
You need to include a suitable fixes tag here. Please repost adding it and retaining Alex's reviwed-by tag, thanks!
Paolo
| |