Messages in this thread | | | Date | Tue, 20 Dec 2022 15:41:25 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] mtd: cfi: allow building spi-intel standalone |
| |
On Tue, Dec 20, 2022, at 06:51, Tudor Ambarus wrote: > On 19.12.2022 17:12, Tokunori Ikegami wrote: >> >> On 2022/12/16 1:39, Arnd Bergmann wrote: >>> From: Arnd Bergmann<arnd@arndb.de> >>> >>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver >>> fails to build, as it includes the shared CFI header: >> The header file linux/mtd/cfi.h is included by the head file >> linux/mtd/spi-nor.h so seems the warning caused. >> Is it really necessary to inculude linux/mtd/cfi.h from >> linux/mtd/spi-nor.h? >> (It seems that it can be resolved the issue by removing the including >> cfi.h from spi-nor.h if unnecessary.) > > SPI NOR does not depend on CFI. cfi.h shouldn't be included by > spi-nor.h, indeed.
Right, I sent v2 now doing this instead.
Arnd
| |