Messages in this thread | | | Date | Tue, 20 Dec 2022 11:50:07 +0000 | From | Qais Yousef <> | Subject | Re: [RFC PATCH 3/3] sched/fair: Traverse cpufreq policies to detect capacity inversion |
| |
On 12/13/22 18:38, Dietmar Eggemann wrote: > On 12/12/2022 19:43, Qais Yousef wrote: > > On 12/09/22 17:47, Vincent Guittot wrote: > > [...] > > > HMP systems for 1k servers just don't make any sense. A desktop with 128 or > > even 256 HMP cores is a big stretch; and if that exist I don't think there's an > > overhead to worry about here; and I *did* consider this. I measured the impact > > if we have 128 and it was mere 1 or 2 us extra. And that's on under powered > > pine book pro. If such a system exist it'd probably be more performant. > > > >> uclamp_min must not set a CPU overutilized because the CPU is not overutilized > >> in this case. It's only the task that is misfit. You mostly try to bias some > >> behavior to fit your use case. > > > > Maybe we are talking about different things over here. As long as we agree it's > > a misfit task then we are aligned. > > IMHO, utilization is about the running task and uclamp is maintained > taking the runnable tasks into consideration as well. Maybe that's the > source of the different views here?
I don't think so, see below.
> > > As far as I know misfit required overutilized to re-enable load balance. But > > maybe there's a detail that's creating this confusion. > > I think that Vincent is suggesting to let MF load balance happening even > in !OverUtilized (OU). We gather the necessary load-balance statistics > already today in !OU so it is easily to do.
I think this is the cause of confusion. The current as it stands relies on OU being set to enable misfit load balance.
If we decouple them as Vincent suggested - which is a good and independent improvement - then yeah uclamp_min raising overutilized is not necessary. It's just an artifact of how misfit load balance works today.
It's a general good improvement to not load misfit raise overutilized.
As discussed offline, Vincent will post independent patch with this improvement.
Thanks!
-- Qais Yousef
| |