lkml.org 
[lkml]   [2022]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] dt-bindings: m41t80: add xtal load capacitance
From
On 19/12/2022 20:09, Dennis Lambe Jr wrote:
> The ST m41t82 and m41t83 support programmable load capacitance from 3.5
> pF to 17.4 pF. The hardware defaults to 12.5 pF.
>
> The accuracy of the xtal can be calibrated precisely by adjusting the
> load capacicance.
>
> Add default, minimum, and maximum for the standard rtc property
> quartz-load-femtofarads on compatible devices.
>
> Signed-off-by: Dennis Lambe Jr <dennis@sparkcharge.io>
> ---
> .../devicetree/bindings/rtc/st,m41t80.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> index fc9c6da6483f..6b72580dc031 100644
> --- a/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> +++ b/Documentation/devicetree/bindings/rtc/st,m41t80.yaml
> @@ -33,6 +33,11 @@ properties:
> "#clock-cells":
> const: 1
>
> + quartz-load-femtofarads:
> + default: 12500
> + minimum: 3500
> + maximum: 17375
> +
> clock-output-names:
> maxItems: 1
> description: From common clock binding to override the default output clock name.
> @@ -44,8 +49,21 @@ properties:
> clock-frequency:
> const: 32768
>
> + wakeup-source: true

Why do you need it here? It's already accepted in rtc.yaml. Adding it is
not explained in commit msg.

> +
> allOf:


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:15    [W:0.060 / U:2.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site