Messages in this thread | | | Date | Tue, 20 Dec 2022 08:50:28 +0100 | From | Michal Swiatkowski <> | Subject | Re: [PATCH v2] iavf/iavf_main: actually log ->src mask when talking about it |
| |
On Tue, Dec 20, 2022 at 09:32:46AM +0300, Daniil Tatianin wrote: > This fixes a copy-paste issue where dev_err would log the dst mask even > though it is clearly talking about src. > > Found by Linux Verification Center (linuxtesting.org) with the SVACE > static analysis tool. > > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") > Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru> > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index c4e451ef7942..adc02adef83a 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -3850,7 +3850,7 @@ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, > field_flags |= IAVF_CLOUD_FIELD_IIP; > } else { > dev_err(&adapter->pdev->dev, "Bad ip src mask 0x%08x\n", > - be32_to_cpu(match.mask->dst)); > + be32_to_cpu(match.mask->src)); > return -EINVAL; > } > } > -- > 2.25.1
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
It is good practise to include changelog in message when You send another version. For example:
v1: * change fix tag to 12 chars
| |