Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property | Date | Tue, 20 Dec 2022 09:34:27 +0200 |
| |
Hi,
Rob Herring <robh@kernel.org> writes:
> The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't > allowed by the schema: > > usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected) > > Allow DWC3 nodes to have a single power-domains entry. We could instead > move the power-domains property to the parent wrapper node, but the > could be an ABI break (Linux shouldn't care). Also, we don't want to > encourage the pattern of wrapper nodes just to define resources such as > clocks, resets, power-domains, etc. when not necessary. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 6d78048c4613..bcefd1c2410a 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -91,6 +91,9 @@ properties: > - usb2-phy > - usb3-phy > > + power-domains: > + maxItems: 1
AFAICT this can be incorrect. Also, you could have Cc the dwc3 maintainer to get comments.
@Thinh, how many power rails does dwc3 need? I don't have access to a databook anymore, but I have a vague memory that different parts of dwc3 could, potentially, be powered by completely separate supplies, no? Or is that only the case for clock domains in dwc3?
-- balbi [unhandled content-type:application/pgp-signature]
| |