Messages in this thread | | | From | Yangtao Li <> | Subject | Re: [PATCH] f2fs: maintain discard in separated file | Date | Wed, 21 Dec 2022 12:07:47 +0800 |
| |
Dear Jaegeuk,
>> This patch moves discard related code from segment.c into discard.c >> since discard is independent feature, and it's better to maintain them >> in separated place. >> >> There is no functionality change. > > Please check Jaegeuk's comments on similar patch:
> https://lore.kernel.org/linux-f2fs-devel/20180426160819.GI68594@jaegeuk-macbookpro.roam.corp.google.com/
How about to pick Chao' patch?
Discard is a relatively independent feature, maybe we can move it to an independent position. And for systems that do not support discard, use CONFIG_F2FS_DISACRD=n to cut this part of the code?
Thx, Yangtao
| |