Messages in this thread | | | Date | Wed, 21 Dec 2022 02:41:50 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v7 11/11] dt-bindings: net: dsa: qca8k: add LEDs definition example |
| |
> > > + }; > > > + > > > + led@1 { > > > + reg = <1>; > > > + color = <LED_COLOR_ID_AMBER>; > > > + function = LED_FUNCTION_LAN; > > > + function-enumerator = <1>; > > > > Typo? These are supposed to be unique. Can't you use 'reg' in your case? > > reg in this context is the address of the PHY on the MDIO bus. This is > an Ethernet switch, so has many PHYs, each with its own address.
Actually, i'm wrong about that. reg in this context is the LED number of the PHY. Typically there are 2 or 3 LEDs per PHY.
There is no reason the properties need to be unique. Often the LEDs have 8 or 16 functions, identical for each LED, but with different reset defaults so they show different things.
Andrew
| |