lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] KVM: x86: Optimize your code to avoid unnecessary calls
From
Hi,

thanks for your contribution! We can improve the code even further
though. You are still calling kvm_pic_update_irq() after
kvm_set_ioapic(), and that is also unnecessary.

On 12/1/22 02:42, liujing wrote:
> @@ -6047,11 +6042,10 @@ static int kvm_vm_ioctl_set_irqchip(struct kvm *kvm, struct kvm_irqchip *chip)
> kvm_set_ioapic(kvm, &chip->chip.ioapic);
> break;
> default:
> - r = -EINVAL;
> - break;
> + return -EINVAL;
> }
> kvm_pic_update_irq(pic);
> - return r;

Please make instead a new function:

void
kvm_set_pic(struct kvm *kvm, int n, struct kvm_pic_state *state)
{
struct kvm_pic *s = kvm->arch.vpic;

pic_lock(s);
memcpy(...)
pic_update_irq(s);
pic_unlock(s);
}

that lets you replace kvm_pic_update_irq() altogether.

Thanks!

Paolo

\
 
 \ /
  Last update: 2022-12-02 19:47    [W:0.030 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site