lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation
On 2022-11-20 16:00, Vladimir Oltean wrote:
> On Sun, Nov 20, 2022 at 11:21:08AM +0100, netdev@kapio-technology.com
> wrote:
>> I have something like this, using 'mvls vtu' from
>> https://github.com/wkz/mdio-tools:
>> VID FID SID P Q F 0 1 2 3 4 5 6 7 8 9 a
>> 0 0 0 y - - = = = = = = = = = = =
>> 1 2 0 - - - u u u u u u u u u u =
>> 4095 1 0 - - - = = = = = = = = = = =
>>
>> as a vtu table. I don't remember exactly the consequences, but I am
>> quite
>> sure that fid=0 gave
>> incorrect handling, but there might be something that I have missed as
>> to
>> other setups.
>
> Can you please find out? There needs to be an answer as to why
> something
> which shouldn't happen happens.

Hi Vladimir,
I haven't been able to reproduce the situation with fid=0, and it may be
superfluous to check if fid has a non-zero value as the case of fid=0 in
the miss violation handling is not valid on a bridged port, where I
understand from consultation that the case fid=0 corresponds to a
non-bridged port.

What I experienced then might have been from some previous bug at a
time, but I don't know.

Should I remove the check or not?

\
 
 \ /
  Last update: 2022-12-02 12:06    [W:0.066 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site