lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/5] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible
On 01/12/2022 11:58, Krzysztof Kozlowski wrote:
> On 30/11/2022 11:29, Neil Armstrong wrote:
>> This documents the compatible for the component used to boot the
>> aDSP, cDSP and MPSS on the SM8550 SoC.
>>
>> The SM8550 boot process on SM8550 now requires a secondary "Devicetree"
>> firmware to be passed along the main Firmware, and the cDSP a new power
>> domain named "NSP".
>>
>> A third memory domain for the DSM memory zone is also needed for the MPSS
>> PAS bindings.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm8550-adsp-pas
>> + then:
>> + properties:
>> + power-domains:
>> + items:
>> + - description: LCX power domain
>> + - description: LMX power domain
>> + power-domain-names:
>> + items:
>> + - const: lcx
>> + - const: lmx
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,sm8550-cdsp-pas
>> + then:
>> + properties:
>> + power-domains:
>> + items:
>> + - description: CX power domain
>> + - description: MXC power domain
>> + power-domain-names:
>> + items:
>> + - const: cx
>> + - const: mxc
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sm8550-cdsp-pas
>
> This entire if does not look valid - compatible is covered in the
> previous one. You should see `dtbs_check` warnings on your DTS.

Wow indeed, this should be mpss-pas...

The main changes here was firmware-name and memory-region to handle
the dtb firmware and the DSM memory region, are those OK ?

Neil

>
>> + then:
>> + properties:
>> + power-domains:
>> + items:
>> + - description: CX power domain
>> + - description: MXC power domain
>> + - description: NSP power domain
>> + power-domain-names:
>> + items:
>> + - const: cx
>> + - const: mxc
>> + - const: nsp
>> +
>> +unevaluatedProperties: false
>> +
>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2022-12-02 11:34    [W:0.081 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site