Messages in this thread | | | Date | Fri, 2 Dec 2022 09:57:53 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH v5 4/7] arm64: dts: Add DT node for the VIPNano-QI on the A311D |
| |
On 01/12/2022 23:33, Martin Blumenstingl wrote: > On Thu, Dec 1, 2022 at 11:31 AM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote: > [...] >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> index 45947c1031c4..61c8461df614 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> @@ -11,6 +11,7 @@ >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> #include <dt-bindings/reset/amlogic,meson-g12a-reset.h> >> #include <dt-bindings/thermal/thermal.h> >> +#include <dt-bindings/power/meson-g12a-power.h> > We could now remove the meson-g12a-power include from > arch/arm64/boot/dts/amlogic/meson-g12.dtsi > I'm not sure if we have any "rule" about this though, so I'm curious > to hear what others think.
Actually you're right, Tomeu please remove this include and remove the: power-domains = <&pwrc PWRC_G12A_NNA_ID>;
and move it as:
&npu { power-domains = <&pwrc PWRC_G12A_NNA_ID>; };
into arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
and while you're at it, please add: &npu { power-domains = <&pwrc PWRC_SM1_NNA_ID>; };
into arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
It's ok to do all this in a single patch.
> > > Best regards, > Martin
(PS: Don't forget Philipp's Acked-by on patch 1 for next version)
Thanks, Neil
| |