lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list
    From
    On 12/2/22 10:36, Kristen Carlson Accardi wrote:
    > + spin_lock(&sgx_global_lru.lock);
    > for (i = 0; i < SGX_NR_TO_SCAN; i++) {
    > - if (list_empty(&sgx_active_page_list))
    > + epc_page = sgx_epc_pop_reclaimable(&sgx_global_lru);
    > + if (!epc_page)
    > break;

    One other nit about the structure of the patches: This introduced *both*
    reclaimable and unreclaimable list_heads. But, it has zero use for the
    unreclaimable ones during the refactoring here. I probably would have
    left out the 'unreclaimable' bits for now.

    BTW, this is a nice sign:

    > arch/x86/kernel/cpu/sgx/main.c | 39 +++++++++++++++++-----------------
    > 1 file changed, 19 insertions(+), 20 deletions(-)


    \
     
     \ /
      Last update: 2022-12-02 22:45    [W:6.135 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site