Messages in this thread | | | Date | Fri, 2 Dec 2022 13:43:52 -0800 | Subject | Re: [PATCH v2 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list | From | Dave Hansen <> |
| |
On 12/2/22 10:36, Kristen Carlson Accardi wrote: > + spin_lock(&sgx_global_lru.lock); > for (i = 0; i < SGX_NR_TO_SCAN; i++) { > - if (list_empty(&sgx_active_page_list)) > + epc_page = sgx_epc_pop_reclaimable(&sgx_global_lru); > + if (!epc_page) > break;
One other nit about the structure of the patches: This introduced *both* reclaimable and unreclaimable list_heads. But, it has zero use for the unreclaimable ones during the refactoring here. I probably would have left out the 'unreclaimable' bits for now.
BTW, this is a nice sign:
> arch/x86/kernel/cpu/sgx/main.c | 39 +++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 20 deletions(-)
| |