lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit()
From
On 12/19/2022 00:40, Perry Yuan wrote:
> replace the sprintf with a more generic sysfs_emit function
>
> No potential function impact

Anything is possible! "No intended functional impact." I believe is
what you meant =)

>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

With commit message fixed:

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
> drivers/cpufreq/amd-pstate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index e8996e937e63..d8b182614c18 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -709,7 +709,7 @@ static ssize_t show_amd_pstate_max_freq(struct cpufreq_policy *policy,
> if (max_freq < 0)
> return max_freq;
>
> - return sprintf(&buf[0], "%u\n", max_freq);
> + return sysfs_emit(buf, "%u\n", max_freq);
> }
>
> static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *policy,
> @@ -722,7 +722,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli
> if (freq < 0)
> return freq;
>
> - return sprintf(&buf[0], "%u\n", freq);
> + return sysfs_emit(buf, "%u\n", freq);
> }
>
> /*
> @@ -737,7 +737,7 @@ static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy,
>
> perf = READ_ONCE(cpudata->highest_perf);
>
> - return sprintf(&buf[0], "%u\n", perf);
> + return sysfs_emit(buf, "%u\n", perf);
> }
>
> static ssize_t show_energy_performance_available_preferences(

\
 
 \ /
  Last update: 2023-03-26 23:15    [W:0.385 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site