Messages in this thread | | | Date | Mon, 19 Dec 2022 16:03:35 -0600 | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries |
| |
On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also > contains: > nxp,pcf2129 > ncp,pca2129 > > Add these missing entries. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > index cde7b1675ead..00dbae7e23c2 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > @@ -14,7 +14,10 @@ maintainers: > > properties: > compatible: > - const: nxp,pcf2127 > + enum: > + - nxp,pcf2127 > + - nxp,pcf2129 > + - ncp,pca2129
Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
Maybe they aren't trivial after all and should be removed? Or nxp,pcf2127 is also trivial?
Rob
P.S. 'make dt_compatible_check' will check in the kernel for undocumented (by a schema) compatibles.
| |