lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Add a way to filter function addresses to function names
On Mon, 19 Dec 2022 10:38:50 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> > index 33e0b4f8ebe6..db6e2f399440 100644
> > --- a/kernel/trace/trace_events.c
> > +++ b/kernel/trace/trace_events.c
> > @@ -2822,7 +2822,7 @@ static __init int setup_trace_triggers(char *str)
> > if (!trigger)
> > break;
> > bootup_triggers[i].event = strsep(&trigger, ".");
> > - bootup_triggers[i].trigger = strsep(&trigger, ".");
> > + bootup_triggers[i].trigger = strsep(&trigger, "");
>
> Would it be better to change to:
>
> bootup_triggers[i].trigger = trigger;
>

Sure, I'll make the update.

> Because there is unnecessary loop if call strsep(s, "") :-)
> strsep(s, ct) {
> strpbrk(cs, ct) {
> // when 'ct' is empty string, here will always return NULL
> // after traversing string 'cs'

I'm not sure what you mean about an extra loop.

Thanks,

-- Steve

\
 
 \ /
  Last update: 2022-12-19 19:21    [W:0.102 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site