lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/5] drivers: mmc: sdhci-cadence: SD6 controller support
    From
    On 19/12/2022 15:24, Piyush Malgujar wrote:
    > From: Dhananjay Kangude <dkangude@cadence.com>
    >
    > This patch includes changes done to support SD6 controller:

    Do not use "This commit/patch".
    https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

    > - Added SD6 related ops which are isolated from SD4
    > - changes to support HS400, HS400ES emmc mode
    > - Updated HS200 tuning values and support to read tune configuration
    > from FDT.
    > - Support to configure host side drive strength and slew
    > and read it from device tree
    >


    (...)

    >
    > @@ -455,7 +1752,14 @@ static const struct of_device_id sdhci_cdns_match[] = {
    > .compatible = "socionext,uniphier-sd4hc",
    > .data = &sdhci_cdns_uniphier_pltfm_data,
    > },
    > - { .compatible = "cdns,sd4hc" },
    > + {
    > + .compatible = "cdns,sd4hc",
    > + .data = &sdhci_cdns_sd4_of_data,
    > + },
    > + {
    > + .compatible = "cdns,sd6hc",
    > + .data = &sdhci_cdns_sd6_of_data,
    > + },

    Your bindings said something different - every sd4hc is compatible with
    sd6hc.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-12-19 16:43    [W:5.713 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site