Messages in this thread | | | Date | Mon, 19 Dec 2022 21:04:02 +0530 | From | Siddh Raman Pant <> | Subject | Re: [PATCH] drm: Replace DRM_INFO() with pr_info() |
| |
On Mon, 19 Dec 2022 20:27:45 +0530, Thomas Zimmermann wrote: > Hi > > Am 19.12.22 um 15:23 schrieb Siddh Raman Pant: > > Line 536 of drm_print.h says DRM_INFO() is deprecated > > in favor of pr_info(). > > That's a misleading comment. DRM_INFO() is deprecated for drm_info(). > pr_info() et al is only to be used of you don't have a dev pointer. > > Best regards > Thomas
Maybe you are confusing it with DRM_DEV_INFO? It takes the dev pointer, and is indeed told to be deprecated in favour of drm_info() in the comments (see line 394).
DRM_INFO is a separate macro for printing stuff, and does not take the dev pointer. They seem to be early wrappers for printk, I guess when pr_info did not exist. And all they do different from pr_info is to add DRM_NAME (which seems to be just "drm") in front of the string.
Thanks, Siddh
| |