Messages in this thread | | | From | "Moger, Babu" <> | Subject | RE: [PATCH v9 04/13] x86/resctrl: Include new features in command line options | Date | Mon, 19 Dec 2022 15:33:55 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Reinette Chatre <reinette.chatre@intel.com> > Sent: Thursday, December 15, 2022 11:12 AM > To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net; > tglx@linutronix.de; mingo@redhat.com; bp@alien8.de > Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org; > hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org; > quic_neeraju@quicinc.com; rdunlap@infradead.org; > damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com; > peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com; > chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com; > jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan > <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com; > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; > bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu; > jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com; > peternewman@google.com > Subject: Re: [PATCH v9 04/13] x86/resctrl: Include new features in command > line options > > Hi Babu, > > On 12/1/2022 7:36 AM, Babu Moger wrote: > > Add the command line options to enable or disable the new resctrl features. > > smba : Slow Memory Bandwidth Allocation bmec : Bandwidth Monitor Event > > Configuration. > > > > Signed-off-by: Babu Moger <babu.moger@amd.com> > > --- > > Documentation/admin-guide/kernel-parameters.txt | 2 +- > > arch/x86/kernel/cpu/resctrl/core.c | 4 ++++ > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > b/Documentation/admin-guide/kernel-parameters.txt > > index 42af9ca0127e..a7b6634f4426 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -5190,7 +5190,7 @@ > > rdt= [HW,X86,RDT] > > Turn on/off individual RDT features. List is: > > cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp, > > - mba. > > + mba, smba, bmec. > > E.g. to turn on cmt and turn off mba use: > > rdt=cmt,!mba > > > > diff --git a/arch/x86/kernel/cpu/resctrl/core.c > > b/arch/x86/kernel/cpu/resctrl/core.c > > index f6af3ac1ef20..10a8c9d96f32 100644 > > --- a/arch/x86/kernel/cpu/resctrl/core.c > > +++ b/arch/x86/kernel/cpu/resctrl/core.c > > @@ -659,6 +659,8 @@ enum { > > RDT_FLAG_L2_CAT, > > RDT_FLAG_L2_CDP, > > RDT_FLAG_MBA, > > + RDT_FLAG_SMBA, > > + RDT_FLAG_BMEC, > > }; > > > > #define RDT_OPT(idx, n, f) \ > > @@ -682,6 +684,8 @@ static struct rdt_options rdt_options[] __initdata = { > > RDT_OPT(RDT_FLAG_L2_CAT, "l2cat", X86_FEATURE_CAT_L2), > > RDT_OPT(RDT_FLAG_L2_CDP, "l2cdp", > X86_FEATURE_CDP_L2), > > RDT_OPT(RDT_FLAG_MBA, "mba", X86_FEATURE_MBA), > > + RDT_OPT(RDT_FLAG_SMBA, "smba", X86_FEATURE_SMBA), > > + RDT_OPT(RDT_FLAG_BMEC, "bmec", X86_FEATURE_BMEC), > > }; > > #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options) > > > > > > > > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Thanks Babu > > Reinette
| |