lkml.org 
[lkml]   [2022]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] kbuild: Optionally enable schema checks for %.dtb targets
    From
    On 12/20/22 02:32, Rob Herring wrote:
    > While not documented, schema checks for single dtb targets mostly work
    > already by setting 'CHECK_DTBS=1'. However, the dependencies are not
    > handled and it only works if 'make dt_bindings_check' was run first and
    > generated processed-schema.json. In addition, changing a binding file
    > doesn't cause the schema to be rebuilt and dtb to be revalidated.
    >
    > Making this work turns out to be simple. Whenever CHECK_DTBS is set,
    > make 'dt_binding_check' a 'dtbs_prepare' dependency.
    >
    > I reimplemented here what Masahiro had originally come up with a while
    > back.
    >
    > Cc: Marek Vasut <marex@denx.de>
    > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    > Signed-off-by: Rob Herring <robh@kernel.org>
    > ---
    > Makefile | 5 ++++-
    > 1 file changed, 4 insertions(+), 1 deletion(-)
    >
    > diff --git a/Makefile b/Makefile
    > index 6aa709df6bde..a99d5c4de0fc 100644
    > --- a/Makefile
    > +++ b/Makefile
    > @@ -1467,7 +1467,10 @@ dtbs_prepare: include/config/kernel.release scripts_dtc
    >
    > ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
    > export CHECK_DTBS=y
    > -dtbs: dt_binding_check
    > +endif
    > +
    > +ifneq ($(CHECK_DTBS),)
    > +dtbs_prepare: dt_binding_check
    > endif
    >
    > dtbs_check: dtbs

    Tested-by: Marek Vasut <marex@denx.de>

    Thank you!

    \
     
     \ /
      Last update: 2023-03-26 23:15    [W:2.259 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site