Messages in this thread | | | From | Toke Høiland-Jørgensen <> | Subject | Re: [PATCH] ath9k: use proper statements in conditionals | Date | Fri, 16 Dec 2022 22:06:59 +0100 |
| |
Kalle Valo <kvalo@kernel.org> writes:
> Toke Høiland-Jørgensen <toke@toke.dk> writes: > >> Arnd Bergmann <arnd@kernel.org> writes: >> >>> From: Arnd Bergmann <arnd@arndb.de> >>> >>> A previous cleanup patch accidentally broke some conditional >>> expressions by replacing the safe "do {} while (0)" constructs >>> with empty macros. gcc points this out when extra warnings >>> are enabled: >>> >>> drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete': >>> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] >>> 251 | TX_STAT_INC(hif_dev, skb_failed); >>> >>> Make both sets of macros proper expressions again. >>> >>> Fixes: d7fc76039b74 ("ath9k: htc: clean up statistics macros") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk> > > I'll queue this to v6.2.
Sounds good, thanks!
-Toke
| |