Messages in this thread | | | Date | Fri, 16 Dec 2022 09:33:19 -0700 | From | Logan Gunthorpe <> | Subject | Re: [PATCH v2 2/2] PCI: switchtec: Return -EFAULT for copy_to_user() errors |
| |
On 2022-12-16 09:21, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > switchtec_dev_read() didn't handle copy_to_user() errors correctly: it > assigned "rc = -EFAULT", but actually returned either "size", -ENXIO, or > -EBADMSG instead. > > Update the failure cases to unlock mrpc_mutex and return -EFAULT directly. > > Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver") > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Looks good to me thanks!
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Logan
| |