Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Fri, 16 Dec 2022 21:50:38 +0800 | Subject | Re: [PATCH v2] soc: mediatek: Add deprecated compatible to mmsys |
| |
On Fri, Dec 16, 2022 at 9:35 PM Matthias Brugger <matthias.bgg@gmail.com> wrote: > > > > On 01/12/2022 12:25, Chen-Yu Tsai wrote: > > On Thu, Dec 1, 2022 at 7:20 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > >> > >> On Mon, Nov 14, 2022 at 7:59 PM AngeloGioacchino Del Regno > >> <angelogioacchino.delregno@collabora.com> wrote: > >>> > >>> Il 11/11/22 09:29, matthias.bgg@kernel.org ha scritto: > >>>> From: Matthias Brugger <matthias.bgg@gmail.com> > >>>> > >>>> For backward compatibility we add the deprecated compatible. > >>>> > >>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > >>> > >>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >>> > >>> ...And tested on MT8195 Cherry Chromebook. > >> > >> This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and > >> vdosys1) that both currently use the -mmsys compatible, which in the driver > >> maps to vdosys0. So not only do we have vdosys1 incorrectly probing as > >> vdosys0, we also have duplicate clks being registered and duplicate DRM > >> pipelines. On my device vdosys1 ends up winning the duplicate clock race. > >> > >> I suggest just reverting this. The display stuff won't be useful unless > >> the drivers are able to distinguish themselves from one another. > > > > That and try to fix the vdosys0 node ASAP. > > I'm not sure what you mean? If there are any patches that are in my queue that > needs attention, please let me know.
It was more of a P.S. note.
| |