lkml.org 
[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESENDv2] arm: topology: Consider clock-frequency property from parent /cpus node
Hi,

On Fri, Dec 16, 2022 at 01:41:58PM +0100, Stefan Wiehler wrote:
> + cn = of_get_cpu_node(cpu, NULL);
> + if (!cn)
> + pr_err("missing device node for CPU %d\n", cpu);
> + cn = of_get_parent(cn);

Doesn't this need to do an of_node_put()?

> + if (!cn)
> + pr_err("missing parent node for CPU %d\n", cpu);
> + common_rate = of_get_property(cn, "clock-frequency", &common_rate_len);

And here too?

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2022-12-16 13:54    [W:0.050 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site