Messages in this thread | | | From | "Moger, Babu" <> | Subject | RE: [PATCH v9 02/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA | Date | Thu, 15 Dec 2022 21:30:32 +0000 |
| |
[AMD Official Use Only - General]
Hi Reinette,
> -----Original Message----- > From: Reinette Chatre <reinette.chatre@intel.com> > Sent: Thursday, December 15, 2022 11:11 AM > To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net; > tglx@linutronix.de; mingo@redhat.com; bp@alien8.de > Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org; > hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org; > quic_neeraju@quicinc.com; rdunlap@infradead.org; > damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com; > peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com; > chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com; > jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan > <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com; > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; > bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu; > jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com; > peternewman@google.com > Subject: Re: [PATCH v9 02/13] x86/resctrl: Add a new resource type > RDT_RESOURCE_SMBA > > Hi Babu, > > On 12/1/2022 7:36 AM, Babu Moger wrote: > > Add a new resource type RDT_RESOURCE_SMBA to handle the QoS > > enforcement policies on the external slow memory. > > > > I think a snippet like below may help to set reviewer's mind at ease about the > consequences of values chosen: > > "Mostly initialization of the essentials. Setting fflags to RFTYPE_RES_MB > configures the SMBA resource to have the same resctrl files as the existing > MBA resource. The SMBA resource has identical properties to the existing MBA > resource. These properties will be enumerated in an upcoming change and > exposed via resctrl because of this flag."
Sure. Will add it. > > > Signed-off-by: Babu Moger <babu.moger@amd.com> > > --- > > arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++++++++ > > arch/x86/kernel/cpu/resctrl/internal.h | 1 + > > 2 files changed, 13 insertions(+) > > > > diff --git a/arch/x86/kernel/cpu/resctrl/core.c > > b/arch/x86/kernel/cpu/resctrl/core.c > > index c98e52ff5f20..f6af3ac1ef20 100644 > > --- a/arch/x86/kernel/cpu/resctrl/core.c > > +++ b/arch/x86/kernel/cpu/resctrl/core.c > > @@ -100,6 +100,18 @@ struct rdt_hw_resource rdt_resources_all[] = { > > .fflags = RFTYPE_RES_MB, > > }, > > }, > > + [RDT_RESOURCE_SMBA] = > > + { > > + .r_resctrl = { > > + .rid = RDT_RESOURCE_SMBA, > > + .name = "SMBA", > > + .cache_level = 3, > > + .domains = > domain_init(RDT_RESOURCE_SMBA), > > + .parse_ctrlval = parse_bw, > > + .format_str = "%d=%*u", > > + .fflags = RFTYPE_RES_MB, > > + }, > > + }, > > }; > > > > /* > > diff --git a/arch/x86/kernel/cpu/resctrl/internal.h > > b/arch/x86/kernel/cpu/resctrl/internal.h > > index 5ebd28e6aa0c..fdbbf66312ec 100644 > > --- a/arch/x86/kernel/cpu/resctrl/internal.h > > +++ b/arch/x86/kernel/cpu/resctrl/internal.h > > @@ -409,6 +409,7 @@ enum resctrl_res_level { > > RDT_RESOURCE_L3, > > RDT_RESOURCE_L2, > > RDT_RESOURCE_MBA, > > + RDT_RESOURCE_SMBA, > > > > /* Must be the last */ > > RDT_NUM_RESOURCES, > > > > > > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Thanks Babu > > Reinette
| |