Messages in this thread | | | Subject | Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to mm/internal.h | From | Muchun Song <> | Date | Thu, 15 Dec 2022 13:31:24 +0800 |
| |
> On Dec 15, 2022, at 13:09, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote: > > On 12/14/22 7:44 PM, Muchun Song wrote: >>> On Dec 14, 2022, at 05:20, Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote: >>> >>> folio_set_compound_order() is moved to an mm-internal location so external >>> folio users cannot misuse this function. Change the name of the function >>> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. Also, >>> handle the case if a non-large folio is passed and add clarifying comments >>> to the function. >>> >>> Link: https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle.com/T/ >>> Fixes: 9fd330582b2f ("mm: add folio dtor and order setter functions") >>> >>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com> >>> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com> >>> Suggested-by: Muchun Song <songmuchun@bytedance.com> >>> Suggested-by: Matthew Wilcox <willy@infradead.org> >>> Suggested-by: John Hubbard <jhubbard@nvidia.com> >> Reviewed-by: Muchun Song <songmuchun@bytedance.com> > Hi Muchun, > > Does this review include the change from
Yes.
Thanks.
> > + if (!folio_test_large(folio)) { > + WARN_ON_ONCE(order); > + return; > + } > > to > > if (WARN_ON_ONCE(!folio_test_large(folio))) > return; > > discussed in in this thread? > > Thanks, > Sidhartha Kumar >> Thanks.
| |