Messages in this thread | | | Subject | Re: [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description | From | Alexander Sverdlin <> | Date | Thu, 15 Dec 2022 17:25:04 +0100 |
| |
Thanks Krzysztof, Rob,
I'll incorporate your comments into the next version, but...
On Thu, 2022-12-15 at 10:18 -0600, Rob Herring wrote: > > + clock-names: > > + const: ep93xx-adc > > Weird name for a clock. Generally is signal name or what it > controls (e.g. bus, core, etc.). Perhaps just drop it. > > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/cirrus,ep93xx-clock.h>
your robot was right, this dependency is missing, I thought I can prepare the ADC driver in advance, but seems it has to go together with the whole DT conversion of the EP93xx series.
-- Alexander Sverdlin.
| |