lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one
On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
> From: Lixue Liang <lianglixue@greatwall.com.cn>
>
> Add the module parameter "allow_invalid_mac_address" to control the
> behavior. When set to true, a random MAC address is assigned, and the
> driver can be loaded, allowing the user to correct the invalid MAC address.
>
> Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>


I'm amused that we are in v7 version of module parameter.

NAK to any module driver parameter. If it is applicable to all drivers,
please find a way to configure it to more user-friendly. If it is not,
try to do the same as other drivers do.

Thanks

\
 
 \ /
  Last update: 2022-12-14 08:23    [W:0.129 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site