Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Wed, 14 Dec 2022 14:53:19 +0100 | Subject | Re: [PATCH] thermal: intel: Don't set HFI status bit to 1 |
| |
On Wed, Dec 14, 2022 at 4:16 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Tue, Dec 13, 2022 at 6:07 PM Srinivas Pandruvada > <srinivas.pandruvada@linux.intel.com> wrote: > > > > When CPU doesn't support HFI (Hardware Feedback Interface), don't include > > BIT 26 in the mask to prevent clearing. otherwise this results in: > > unchecked MSR access error: WRMSR to 0x1b1 > > (tried to write 0x0000000004000aa8) > > at rIP: 0xffffffff8b8559fe (throttle_active_work+0xbe/0x1b0) > > > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > > Fixes: 6fe1e64b6026 ("thermal: intel: Prevent accidental clearing of HFI status") > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > You can add my tested-by as well, it seems to fix the issue. > > Of course, it could be that I just didn't happen to trigger the > throttling in my test just now, so that testing is pretty limited, but > at least from a very quick check it seems good.
I've applied the patch for 6.2-rc1, thanks!
| |