Messages in this thread | | | From | Yuwei Guan <> | Date | Tue, 13 Dec 2022 17:24:46 +0800 | Subject | Re: [PATCH v2] f2fs: continuous counting for 'issued' in __issue_discard_cmd_orderly() |
| |
Bagas Sanjaya <bagasdotme@gmail.com> 于2022年12月11日周日 21:20写道: > > On Sun, Dec 11, 2022 at 08:18:52PM +0800, Yuwei Guan wrote: > > As the 'dcc->discard_granularity' and 'dcc->max_ordered_discard' can be set > > at the user space, and if the 'dcc->max_ordered_discard' is set larger than > > 'dcc->discard_granularity' in DPOLICY_BG mode, or it's a volume device, > > discard_granularity can be tuned to 1 in f2fs_tuning_parameters(), > > it will may send more requests than the number of 'dpolicy->max_requests' > > in issue_discard_thread(). > > > > You don't know how to stop sentences (aka "abusing" comma), so I read > above as uber-long sentence. Care to reword? There are many cases when I > have to reply with such rewording, but this time I choose not to do > because I'm lazy at the time I write this reply. > Hi Bagas, Thanks for your review. Sorry for submitting a poorly described patch, I will update a v3 patch to rewrite the issue description and solution. > > This patch will fix the issue. > > Fix by what? I don't understand the code. > > > > > Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com> > > You send from your Gmail address but have SoB from either personal email > domain or is this a random company? If it is the latter, please talk > with your company to fix the mail system so that you can send from its > domain (and receive traffic from mailing lists). In any case, your email > address in From header and SoB must match. > The email system has been fixed, and the email addresses will match in the future. > Thanks. > > -- > An old man doll... just what I always wanted! - Clara
| |