Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [for-next][PATCH 13/25] x86/mm/kmmio: Use rcu_read_lock_sched_notrace() | Date | Mon, 12 Dec 2022 11:51:51 +0100 |
| |
On Sat, Dec 10 2022 at 18:55, Steven Rostedt wrote: > On Sun, 11 Dec 2022 00:30:36 +0100 > Thomas Gleixner <tglx@linutronix.de> wrote: >> I concede that there are hot paths which actually can benefit, but this >> code has exactly _ZERO_ benefit from that. Taking that tracing exception >> and handling it is orders of magnitudes more expensive than a regular >> preempt_enable(). >> >> So just get rid of it and don't proliferate cargo cult programming. >> > The point of the patch is to just fix the lockdep issue. I'm happy to > remove that "no_resched" (I was planning to), but that would be a separate > change, with a different purpose, and thus a separate patch.
Right, but please make that part of the series.
Thanks,
tglx
| |