lkml.org 
[lkml]   [2022]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node
From
On 12/12/2022 10:18, Konrad Dybcio wrote:
>
>
> On 12.12.2022 10:17, Krzysztof Kozlowski wrote:
>> On 12/12/2022 10:15, Konrad Dybcio wrote:
>>>>>> +
>>>>>> + qup_opp_table: opp-table-qup {
>>>>>> + compatible = "operating-points-v2";
>>>>>> +
>>>>>> + opp-75000000 {
>>>>>> + opp-hz = /bits/ 64 <75000000>;
>>>>>> + required-opps = <&rpmhpd_opp_low_svs>;
>>>>>> + };
>>>>>> +
>>>>>> + opp-100000000 {
>>>>>> + opp-hz = /bits/ 64 <100000000>;
>>>>>> + required-opps = <&rpmhpd_opp_svs>;
>>>>>> + };
>>>>>> +
>>>>>> + opp-128000000 {
>>>>>> + opp-hz = /bits/ 64 <128000000>;
>>>>>> + required-opps = <&rpmhpd_opp_nom>;
>>>>>> + };
>>>>>> + };
>>>>>> +
>>>>>> memory@80000000 {
>>>>> Sidenote: memory@ should be moved above opp-*, alphabetically
>>>>>
>>>>> For this:
>>>>>
>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>
>>>> You sure? Because before there is already opp for cpu...
>>> Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes
>>> before 'o'.
>>
>> So you want to have broken order?
>> opp-table-cpu
>> memory
>> opp-table-qup
>> ?
>>
>> They are at least all together in my patch.
> No, I meant:
>
> memory
> opp-table-cpu
> opp-table-qup

OK, I'll correct the opp-table-cpu/memory order in separate patch.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-12-12 10:26    [W:0.055 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site