lkml.org 
[lkml]   [2022]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wlan-ng: fix checkpatch error for spinlock
On Sun, Dec 11, 2022 at 12:06:04PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote:
> > Checkpatch Styleproblem fixed by adding comment.
> >
> > Signed-off-by: Dalvin <pharcodra@gmail.com>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 0611e37df6ac..ad117d570bb6 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx {
> > };
> >
> > struct hfa384x_usbctlxq {
> > + /* lock: Protect structure fields */

Also, does this comment really make sense? To properly document a lock
takes a bit more text, if you read this would it help out in
understanding the code any?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-12-11 12:34    [W:0.043 / U:1.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site