lkml.org 
[lkml]   [2022]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] fs/ufs: Change the signature of ufs_get_page()
On Sun, Dec 11, 2022 at 10:31:10PM +0100, Fabio M. De Francesco wrote:
> out_put:
> ufs_put_page(page);
> -out:
> - return err;
> out_unlock:
> unlock_page(page);
> goto out_put;

Something strange has happened, all right - look at the situation
after that patch. You've got

out_put:
ufs_put_page(page);
out_unlock:
unlock_page(page);
goto out_put;

Which is obviously bogus.

\
 
 \ /
  Last update: 2022-12-11 23:43    [W:0.133 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site