Messages in this thread |  | | Date | Sat, 10 Dec 2022 21:51:43 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 2/5] nolibc: add support for s390 |
| |
On Sat, Dec 10, 2022 at 11:05:04PM +0100, Willy Tarreau wrote: > On Sat, Dec 10, 2022 at 09:57:14AM -0800, Paul E. McKenney wrote: > > On Sat, Dec 10, 2022 at 10:44:52AM +0100, Willy Tarreau wrote: > > > On Sat, Dec 10, 2022 at 10:39:43AM +0100, Sven Schnelle wrote: > > > > Willy Tarreau <w@1wt.eu> writes: > > > > > > > > > On Sat, Dec 10, 2022 at 10:34:08AM +0100, Sven Schnelle wrote: > > > > >> So it should be: > > > > >> > > > > >> >> +#elif defined(__s390x__) > > > > >> >> +#include "arch-s390.h" > > > > >> > > > > >> I'm fine with both - either you fixing it up or me sending a v2. > > > > > > > > > > As you like. If you prefer to rename the file to s390x as your colleague > > > > > suggested, I'll then ask you to send a v2. Otherwise either Paul or I can > > > > > drop that 'x' in the #include. > > > > > > > > Just drop the 'x'. Thanks! :) > > > > > > OK will do, thank you! > > > > And I have queued this series with Willy's acks on the first three and > > the "x" removed from the '#include "arch-s390x.h"'. This is on the -rcu > > tree's "dev" branch. > > > > But please double-check to make sure that I removed the correct "x" > > and that there are not others that I missed! > > Just checked, looks good to me, many thanks Paul!
Whew! And thank you for checking!
Thanx, Paul
|  |