Messages in this thread |  | | From | Max Filippov <> | Date | Sat, 10 Dec 2022 06:48:02 -0800 | Subject | Re: [PATCH v1] spi: xtensa-xtfpga: Fix a double put() in xtfpga_spi_remove() |
| |
Hi Christophe,
On Sat, Dec 10, 2022 at 3:52 AM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'master' is allocated with devm_spi_alloc_master(), there is no need to > put it explicitly in the remove function. > > Fixes: 478cc2fc3dd7 ("spi: xtensa-xtfpga: Switch to use devm_spi_alloc_master()") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/spi/spi-xtensa-xtfpga.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/spi/spi-xtensa-xtfpga.c b/drivers/spi/spi-xtensa-xtfpga.c > index 2fa7608f94cd..271ae98f441c 100644 > --- a/drivers/spi/spi-xtensa-xtfpga.c > +++ b/drivers/spi/spi-xtensa-xtfpga.c > @@ -123,7 +123,6 @@ static int xtfpga_spi_remove(struct platform_device *pdev) > struct xtfpga_spi *xspi = spi_master_get_devdata(master); > > spi_bitbang_stop(&xspi->bitbang); > - spi_master_put(master);
This put is matching the get in the spi_bitbang_start. It was discussed here: https://lore.kernel.org/linux-spi/CAMo8BfJaD7pG_iutY8jordysjChyzhTpVSqpxXh3QoZsj2QmaQ@mail.gmail.com/
-- Thanks. -- Max
|  |