Messages in this thread | | | Date | Thu, 1 Dec 2022 20:42:30 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration |
| |
On Thu, Dec 01, 2022 at 07:30:16PM +0000, Conor Dooley wrote: > On Thu, Dec 01, 2022 at 05:49:08PM +0000, Conor Dooley wrote: > > On Thu, Dec 01, 2022 at 05:02:42PM +0800, Yanhong Wang wrote: > > > riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration > > > > > > Add phy delay_chain configuration to support motorcomm phy driver for > > > StarFive VisionFive 2 board. > > nit: please re-word this commit next time around to actually say what > you're doing here. I didn't notice it initially, but this patch is doing > a lot more than adding `delay_chain` configuration. To my dwmac unaware > brain, there's nothing hits for that term outside of the changelog :(
Hi Conor
I suspect once we see the documentation of the binding, it will get rejected and implemented differently. So i would not worry too much about this at the moment.
Andrew
| |