lkml.org 
[lkml]   [2022]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/4] usb.h: take advantage of container_of_const()
Date
Instead of rolling our own const-checking logic in to_usb_interface()
and to_usb_device() use the newly added container_of_const() instead,
making the logic much simpler overall.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/linux/usb.h | 44 ++++----------------------------------------
1 file changed, 4 insertions(+), 40 deletions(-)

diff --git a/include/linux/usb.h b/include/linux/usb.h
index 4b463a5e4ba2..cd5637c950ae 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -259,26 +259,8 @@ struct usb_interface {
struct work_struct reset_ws; /* for resets in atomic context */
};

-static inline struct usb_interface *__to_usb_interface(struct device *d)
-{
- return container_of(d, struct usb_interface, dev);
-}
-
-static inline const struct usb_interface *__to_usb_interface_const(const struct device *d)
-{
- return container_of(d, struct usb_interface, dev);
-}
-
-/*
- * container_of() will happily take a const * and spit back a non-const * as it
- * is just doing pointer math. But we want to be a bit more careful in the USB
- * driver code, so manually force any const * of a device to also be a const *
- * to a usb_device.
- */
-#define to_usb_interface(dev) \
- _Generic((dev), \
- const struct device *: __to_usb_interface_const, \
- struct device *: __to_usb_interface)(dev)
+#define to_usb_interface(__dev) \
+ container_of_const(struct device, __dev, struct usb_interface, dev)

static inline void *usb_get_intfdata(struct usb_interface *intf)
{
@@ -730,26 +712,8 @@ struct usb_device {
unsigned use_generic_driver:1;
};

-static inline struct usb_device *__to_usb_device(struct device *d)
-{
- return container_of(d, struct usb_device, dev);
-}
-
-static inline const struct usb_device *__to_usb_device_const(const struct device *d)
-{
- return container_of(d, struct usb_device, dev);
-}
-
-/*
- * container_of() will happily take a const * and spit back a non-const * as it
- * is just doing pointer math. But we want to be a bit more careful in the USB
- * driver code, so manually force any const * of a device to also be a const *
- * to a usb_device.
- */
-#define to_usb_device(dev) \
- _Generic((dev), \
- const struct device *: __to_usb_device_const, \
- struct device *: __to_usb_device)(dev)
+#define to_usb_device(__dev) \
+ container_of_const(struct device, __dev, struct usb_device, dev)

static inline struct usb_device *__intf_to_usbdev(struct usb_interface *intf)
{
--
2.38.1
\
 
 \ /
  Last update: 2022-12-01 20:33    [W:0.130 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site